Don't use first_action without initializing it if n_entries is 0.

Fri Dec 26 23:24:35 2003  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full):
	Don't use first_action without initializing it if n_entries is 0.

diff --git a/ChangeLog b/ChangeLog
index d918ebb9f433fae50827c19663633e6e4ff29c03..c6f46063fcf138fdd73a6b6124cda48def9b92b1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Fri Dec 26 23:24:35 2003  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full): 
+       Don't use first_action without initializing it if n_entries is 0.
+
 Thu Dec 25 00:26:34 2003  Matthias Clasen  <maclas@gmx.de>
 
        * gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index d918ebb9f433fae50827c19663633e6e4ff29c03..c6f46063fcf138fdd73a6b6124cda48def9b92b1 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+Fri Dec 26 23:24:35 2003  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full): 
+       Don't use first_action without initializing it if n_entries is 0.
+
 Thu Dec 25 00:26:34 2003  Matthias Clasen  <maclas@gmx.de>
 
        * gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index d918ebb9f433fae50827c19663633e6e4ff29c03..c6f46063fcf138fdd73a6b6124cda48def9b92b1 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,8 @@
+Fri Dec 26 23:24:35 2003  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full): 
+       Don't use first_action without initializing it if n_entries is 0.
+
 Thu Dec 25 00:26:34 2003  Matthias Clasen  <maclas@gmx.de>
 
        * gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index d918ebb9f433fae50827c19663633e6e4ff29c03..c6f46063fcf138fdd73a6b6124cda48def9b92b1 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,8 @@
+Fri Dec 26 23:24:35 2003  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full): 
+       Don't use first_action without initializing it if n_entries is 0.
+
 Thu Dec 25 00:26:34 2003  Matthias Clasen  <maclas@gmx.de>
 
        * gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index d918ebb9f433fae50827c19663633e6e4ff29c03..c6f46063fcf138fdd73a6b6124cda48def9b92b1 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,8 @@
+Fri Dec 26 23:24:35 2003  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full): 
+       Don't use first_action without initializing it if n_entries is 0.
+
 Thu Dec 25 00:26:34 2003  Matthias Clasen  <maclas@gmx.de>
 
        * gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):

diff --git a/gtk/gtkactiongroup.c b/gtk/gtkactiongroup.c
index afbebc61b1d3d440491934cafc105e56d71a9dc1..051010ed633720497781bd1cdb4204aab79b0f1f 100644 (file)
--- a/gtk/gtkactiongroup.c
+++ b/gtk/gtkactiongroup.c
@@ -630,7 +630,7 @@ gtk_action_group_add_radio_actions_full (GtkActionGroup      *action_group,
   GtkTranslateFunc translate_func;
   gpointer translate_data;
   GSList *group = NULL;
-  GtkAction *first_action;
+  GtkAction *first_action = NULL;
 
   g_return_if_fail (GTK_IS_ACTION_GROUP (action_group));
 
@@ -694,7 +694,7 @@ gtk_action_group_add_radio_actions_full (GtkActionGroup      *action_group,
       g_object_unref (action);
     }
 
-  if (on_change)
+  if (on_change && first_action)
     g_signal_connect_data (first_action, "changed",
                           on_change, user_data, 
                           (GClosureNotify)destroy, 0);